Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GitHub Actions #94

Merged
merged 5 commits into from
Nov 22, 2023
Merged

add GitHub Actions #94

merged 5 commits into from
Nov 22, 2023

Conversation

mathiask88
Copy link
Owner

No description provided.

@mathiask88
Copy link
Owner Author

@Apollon77 I tried to be as minimalist as possible. Do you miss any functionality from your PR?

@Apollon77
Copy link

In a first mobile device view looks good. Go ahead

@Apollon77
Copy link

PS: the question is if it not makes sense to add node-gyp as dep to make sure it also works for users with nodes 12/14/16 that most likel never get a new bpm version but python 3.12 will go out next year.

@mathiask88
Copy link
Owner Author

Python version is just for latest macos. They dropped support of disutils in python 3.12. prebuild bundles it's own node-gyp. I would keep this workaround until prebuild upgrades to node-gyp 10 that solves the issue. Instead of forcing python 3.11 I could also install disutils via pip in de CI. Node 12/14/16 should build fine. But they are out of maintenance, so good if it works, but won't put too much effort to get these old versions working.

@Apollon77
Copy link

Sure ... yes with prebuild ideally the issue is also "solved" for the users ... yes

@mathiask88 mathiask88 merged commit 2759e4a into master Nov 22, 2023
40 checks passed
@mathiask88 mathiask88 deleted the github-actions branch November 22, 2023 18:48
@Apollon77
Copy link

@mathiask88 Please check ... 1.0.7 is not available on npm!

@mathiask88
Copy link
Owner Author

I know, still fighting with the CI and old node versions. Will apply a patch this evening or latest on Saturday. And then release the new version to npm.

@Apollon77
Copy link

@mathiask88 did you had any chance?

@mathiask88
Copy link
Owner Author

released on npm.. Sorry I had to deal with the npm/Github service this week (which was very nice and helpful btw) because I never setup 2FA and my account got locked 😅

@Apollon77
Copy link

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants